Gate tree-selection bookkeeping test to macOS#245
Merged
Conversation
The macOS TreeListCtrl shim is the only path that maintains the bookkeeping this test exercises — on Windows/Linux ManagedTreeCtrl is a wx.TreeCtrl whose root becomes invalid after DeleteAllItems and whose stale TreeItemIds give undefined results, so the test fails with a wxAssertionError. Skip it on non-darwin like the existing event-binder test. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_managed_tree_ctrl_delete_all_items_resets_bookkeepingon non-darwin. It exercises the macOSTreeListCtrlshim's bookkeeping (_item_datareset, persistent compat-root); on Windows/LinuxManagedTreeCtrlis awx.TreeCtrlwhose root becomes invalid afterDeleteAllItemsand whose staleTreeItemIds are undefined, so the test fails withwxAssertionError: "item.IsOk()" failed.sys.platform != "darwin"gate ontest_managed_tree_ctrl_rejects_unsupported_tree_event_binders.Test plan
uv run python -m pytest tests/test_tree_selection.py -von Windows: 2 passed, 2 skipped, 0 failed.🤖 Generated with Claude Code